Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks V1/V2 compatibility #450

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Tasks V1/V2 compatibility #450

merged 10 commits into from
Apr 15, 2024

Conversation

zonia3000
Copy link
Collaborator

@zonia3000 zonia3000 commented Apr 12, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Closes #438
Closes #433
Closes #448
Closes #330

@zonia3000
Copy link
Collaborator Author

The new Task V1/V2 compatibility page:

image

Switcher for V1/V2 tasks in workflow page task selector:

image

Legacy tasks inserted in V2 workflow:

image

@zonia3000 zonia3000 requested a review from tcompa April 12, 2024 10:47
@tcompa
Copy link
Collaborator

tcompa commented Apr 12, 2024

The new Task V1/V2 compatibility page:

Looks good to me!
How are we displaying different versions of the same task? Are they still all listed (even if they are not grouped any more)?

Switcher for V1/V2 tasks in workflow page task selector:

I think we should avoid V1 and V2. Maybe "current tasks" and "legacy tasks"?

Legacy tasks inserted in V2 workflow:

Same as above, what about "legacy" instead of "v1"?

@zonia3000
Copy link
Collaborator Author

With multiple versions the old versions are inside collapsed rows, as in the main task list table:

image

Used current/legacy:

image

@jluethi
Copy link
Collaborator

jluethi commented Apr 12, 2024

+1 on using legacy wording.

I think Tommaso's question was for the adding task modal. There, the version selector usually just shows up when a task is selected, I assume it's still the same :)

@tcompa
Copy link
Collaborator

tcompa commented Apr 15, 2024

Task V1 collection:
image

Task V2 collection:
image

Admin V2 sections:
image

Setting V1 tasks as V2-compatible (with single versions):
image

Setting V1 tasks as V2-compatible (with multiple versions available):
image

Minor question: before I expand the "+" button, I can already mark act on the true/false switch, which modifies the latest-version task. I'm not sure this is the most intuitive behavior (at first I thought it would have modified the whole block of tasks, for all versions), but TBH this is an admin-only page and we don't need to invest in polishing too much.

Adding a V2 task into a V2 workflow
image

Adding a V1 task into a V2 workflow (when no V1 task is V2-compatible):
image

Adding a V1 task into a V2 workflow (when there is a single version of the only V2-compatible V1 task):
image

Adding a V1 task into a V2 workflow (when there are two versions of the only V2-compatible V1 task):
image

@tcompa
Copy link
Collaborator

tcompa commented Apr 15, 2024

All works as expected, thanks!
Let's open other issues for polishing this new feature.

@tcompa tcompa merged commit 44e13ea into main Apr 15, 2024
11 checks passed
@tcompa tcompa deleted the task-v1v2-compatibility branch April 15, 2024 06:38
@jluethi
Copy link
Collaborator

jluethi commented Apr 15, 2024

Minor question: before I expand the "+" button, I can already mark act on the true/false switch, which modifies the latest-version task. I'm not sure this is the most intuitive behavior (at first I thought it would have modified the whole block of tasks, for all versions), but TBH this is an admin-only page and we don't need to invest in polishing too much.

I'd encourage only making the most recent version V2 compatible, to avoid supporting too many V1 tasks.

Looks good to me overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants