Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment with fractal-server 2.9.0 #640

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Alignment with fractal-server 2.9.0 #640

merged 10 commits into from
Nov 14, 2024

Conversation

zonia3000
Copy link
Collaborator

@zonia3000 zonia3000 commented Nov 13, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Closes #638
Closes #639

@tcompa
Copy link
Collaborator

tcompa commented Nov 13, 2024

First examples
image
image
image
image
image
image

@tcompa
Copy link
Collaborator

tcompa commented Nov 13, 2024

Minor issues

image
This should not read "Task collection", because it could be a deactivation or reactivation. We can simply use "Task-group activity logs".

image
I would slightly modify this one.

  1. Display a text like "The task group is currently active" (or "not active").
  2. If it's active: show a button like "Deactivate task group". When this is clicked, ask for confirmation (with the same warning as now).
  3. If it's not active: show a button like "Reactivate task group"

@tcompa
Copy link
Collaborator

tcompa commented Nov 13, 2024

As some sort of end-to-end test: I confirm that after a full collect-deactivate-reactivate cycle I can properly use the tasks in a workflow
image

@zonia3000
Copy link
Collaborator Author

Deactivate:

image

image

Reactivate:

image

@zonia3000 zonia3000 merged commit ee08ef0 into main Nov 14, 2024
7 checks passed
@zonia3000 zonia3000 deleted the task-group-activities branch November 14, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dataset-creation modal Align with fractal-server 2.9.0
2 participants