Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created tasks-list module; moved jschema to components module #671

Merged
merged 12 commits into from
Dec 10, 2024

Conversation

zonia3000
Copy link
Collaborator

@zonia3000 zonia3000 commented Dec 9, 2024

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md

Closes #666

@zonia3000 zonia3000 marked this pull request as ready for review December 9, 2024 14:10
@zonia3000 zonia3000 requested a review from tcompa December 9, 2024 14:11
@tcompa
Copy link
Collaborator

tcompa commented Dec 10, 2024

  1. Rename fractal-tasks into task-table (in the URL)
  2. Re-include modal to display docs_info
  3. Add Fractal favicon to tasks-list
  4. Make category and modality clickable
  5. Adapt to iframe

@tcompa
Copy link
Collaborator

tcompa commented Dec 10, 2024

tasks-list (tasks-list-module)$ npm run build

> build
> vite build

▲ [WARNING] Cannot find base config file "./.svelte-kit/tsconfig.json" [tsconfig.json]

    ../jsconfig.json:2:12:
      2 │   "extends": "./.svelte-kit/tsconfig.json",
        ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vite v5.4.8 building SSR bundle for production...
✓ 94 modules transformed.
▲ [WARNING] Cannot find base config file "./.svelte-kit/tsconfig.json" [tsconfig.json]

    ../jsconfig.json:2:12:
      2 │   "extends": "./.svelte-kit/tsconfig.json",

@zonia3000
Copy link
Collaborator Author

Regarding the warning:

▲ [WARNING] Cannot find base config file "./.svelte-kit/tsconfig.json" [tsconfig.json]

../jsconfig.json:2:12:
  2 │   "extends": "./.svelte-kit/tsconfig.json",
    ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

TL;DR: It disappears if you run npm install on the parent folder.

The build detects that there is a jsconfig.json file in the parent folder, so it understands that is currently building a subproject. It then checks if there is a file .svelte-kit/tsconfig.json in the parent folder and doesn't find it, so the warning is displayed. To remove the warning we could run npm install on the parent folder before executing the subproject build, because running npm install also generates the .svelte-kit folder.

However, as stated by a comment on related issue:

the warning is supposed to be harmless. It indicates that whatever build system you use (vercel, netlify, multistage docker builds, ...) didn't populate the .svelte-kit folder before invoking vite build.

So, since we don't really need to run npm install on the parent folder, I would keep our CI steps as they are, to avoid running an extra step only for removing the warning.

@zonia3000 zonia3000 merged commit 6385171 into main Dec 10, 2024
7 checks passed
@zonia3000 zonia3000 deleted the tasks-list-module branch December 10, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract task-list page into separate component, to be re-used in public task-list landing page
2 participants