Unhandled exception when checking if URL exists #101 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle exceptions raised from the use of `requests.exceptions`.
Default value is False. Moved raising the exception behind the parameter.
fralau
added
the
please open issue
|
Please relate this PR to an existing issue, or open one. |
There should be one open already: #101. |
|
The best way to make the link is to indicate, on the right of the pane under "Development", the number of the issue. I did that. 
|
fralau
removed
the
please open issue
EvaSDK
reviewed
Aug 16, 2024
| try: | ||
| request = requests.get(url) | ||
| except Exception as ue: | ||
| if ue.__class__.__module__ == "requests.exceptions": |
There was a problem hiding this comment.
Just catch the exception you want to handle separately direclty.
try:
res = requests.get(url)
except requests.exceptions.RequestException:
warning("Exception when making a GET request: %s" % ue)
return False
else:
return request.status_code == 200There was a problem hiding this comment.
Hum, but this does not cover all exceptions so nevermind.
EvaSDK
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle exceptions raised from the use of
requests.exceptions.Implement warning and critical in the style of the original authors:
Warning is used for capturing the faulty request.
Critical is used to notify user that there is a problem.
I am still leaving the raise FileNotFoundError there as I wanted to make another request for turning this optional.