Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HRIS-250 [FE] Integrate Add New Employee Functionality #215

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsvelte
Copy link
Contributor

@jsvelte jsvelte commented May 15, 2023

Issue Link

Definition of Done

  • Implement client-side validation for all required fields to ensure proper data input.
  • Connect the UI to the back-end API endpoint for adding new employee data.
  • Test the UI thoroughly to ensure it adds new employee data correctly.

Notes

Pre-condition

  • (docker) run docker compose up api db client --build -d
  • (local) run dotnet run in api directory
  • go to http://localhost:5257/graphql/
query {
  allPositions {
    id
    name
  }
}

query {
  allRoles {
    id
    name
  }
}

# Don't forget the nextauth-token in the http header
  • go to http://localhost:3000/employee-management
  • Perform Add New Employee

Expected Output

  • Only Admin user should be able to perform this add action
  • Admin will now be able to create new User

Screenshots/Recordings

record1.webm

@jsvelte jsvelte self-assigned this May 15, 2023
@jsvelte jsvelte force-pushed the feature/hris-250 branch 2 times, most recently from 88619ae to 34a0f2d Compare May 15, 2023 08:57
@jsvelte jsvelte marked this pull request as ready for review May 15, 2023 09:08
@jsvelte jsvelte force-pushed the feature/hris-250 branch from 34a0f2d to 391518d Compare May 15, 2023 09:09
@jsvelte jsvelte force-pushed the feature/hris-250 branch 5 times, most recently from 6cc6b08 to 2bd5c7a Compare May 23, 2023 03:34
@jsvelte jsvelte marked this pull request as draft May 24, 2023 06:46
@jsvelte jsvelte closed this Jun 5, 2023
@jsvelte jsvelte reopened this Jul 7, 2023
@jsvelte jsvelte force-pushed the feature/hris-250 branch 2 times, most recently from 8c2f6b5 to 16a23b7 Compare July 7, 2023 02:12
@jsvelte jsvelte marked this pull request as ready for review July 7, 2023 07:04
@jsvelte jsvelte force-pushed the feature/hris-250 branch from 16a23b7 to 0300273 Compare July 7, 2023 07:05
@jsvelte jsvelte force-pushed the feature/hris-250 branch from 0300273 to 6f0421c Compare July 7, 2023 08:45
@jsvelte jsvelte force-pushed the feature/hris-250 branch from 6f0421c to 4aa59d9 Compare July 7, 2023 10:00
Copy link
Contributor

@arden-dave-sun arden-dave-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants