Skip to content

Commit

Permalink
Merge pull request #69 from franc-pentest/master
Browse files Browse the repository at this point in the history
  • Loading branch information
BastienFaure authored Jun 2, 2024
2 parents d44890b + b139759 commit 99ccf5e
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 8 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,26 @@ jobs:
pdm export -f requirements --without-hashes --dev > requirements.txt
python3.12 -m pip install -r requirements.txt
- name: Build
- name: Build binary release
run: |
python3.12 -m nuitka --standalone --onefile --output-filename=ldeep.bin ldeep/__main__.py
mv ldeep.bin ldeep_linux-amd64
- name: Upload Artifacts
- name: Build Source Distribution
run: pdm build -d sdist --no-wheel

- name: Upload Artifacts (binary)
uses: actions/upload-artifact@v3
with:
name: linux
path: ldeep_linux-amd64

- name: Upload Artifacts (sdist)
uses: actions/upload-artifact@v3
with:
name: sdist
path: sdist/*

windows-build:
name: Windows Build
runs-on: "windows-latest"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ jobs:
- name: Get local version
run: echo "version=$(cat VERSION)" >> $GITHUB_ENV

- name: Build sdist
run: pdm build -d sdist --no-wheel

- name: Create tag
uses: rickstaa/action-create-tag@v1
with:
Expand Down
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.55
1.0.56
2 changes: 0 additions & 2 deletions ldeep/views/ldap_activedirectory.py
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,6 @@ def get_gmsa(self, attributes):
sam = entry["sAMAccountName"]
data = entry["msDS-ManagedPassword"]
readers = entry["msDS-GroupMSAMembership"]

# Find principals who can read the password
try:
readers_sd = parse_ntSecurityDescriptor(readers)
Expand All @@ -717,7 +716,6 @@ def get_gmsa(self, attributes):
pass
except Exception:
pass

blob = MSDS_MANAGEDPASSWORD_BLOB()
try:
blob.fromString(data)
Expand Down

0 comments on commit 99ccf5e

Please sign in to comment.