Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zero copy writes for TCP socket (sync and async) transports #167

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

francis-clairicia
Copy link
Owner

What's changed

  • Default implementations of send_all_from_iterable() do not concatenate received iterable in one byte buffer.
  • Implementations of send_all_from_iterable() for TCP sockets (without SSL) use sendmsg(2) on platforms supporting it (UNIX systems currently).

Unchanged behaviors

@francis-clairicia francis-clairicia added bug Something isn't working topic-tcp Relative to TCP sockets topic-async Relative to asynchronous API topic-sync Relative to synchronous API labels Nov 18, 2023
@francis-clairicia francis-clairicia self-assigned this Nov 18, 2023
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #167 (1d58bb5) into main (8f50e10) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Flag Coverage Δ
OS-Linux 85.88% <68.62%> (-0.41%) ⬇️
OS-Windows 85.25% <48.03%> (-0.66%) ⬇️
OS-macOS 85.91% <68.62%> (-0.41%) ⬇️
Py-3.11 99.89% <100.00%> (+<0.01%) ⬆️
Py-3.12 99.89% <100.00%> (+<0.01%) ⬆️
test-functional 86.16% <75.49%> (-0.18%) ⬇️
test-unit 83.62% <100.00%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francis-clairicia francis-clairicia merged commit 2fb7d26 into main Nov 18, 2023
19 checks passed
@francis-clairicia francis-clairicia deleted the fix/zero-copy-write branch November 18, 2023 11:27
@francis-clairicia francis-clairicia added enhancement New feature or request and removed bug Something isn't working labels Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic-async Relative to asynchronous API topic-sync Relative to synchronous API topic-tcp Relative to TCP sockets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant