Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncSocket: Fixed OSError raised by methods if aclose() is called #175

Merged
merged 1 commit into from
Dec 2, 2023
Merged

AsyncSocket: Fixed OSError raised by methods if aclose() is called #175

merged 1 commit into from
Dec 2, 2023

Conversation

francis-clairicia
Copy link
Owner

AsyncSocket used to raise ECONNABORTED or ENITR instead of EBADF (or ENOTSOCK, both works)

@francis-clairicia francis-clairicia added bug Something isn't working topic-async Relative to asynchronous API labels Dec 2, 2023
@francis-clairicia francis-clairicia self-assigned this Dec 2, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #175 (91bfa5e) into main (3beb7c4) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Flag Coverage Δ
OS-Linux 86.19% <100.00%> (+0.03%) ⬆️
OS-Windows 85.60% <100.00%> (+0.03%) ⬆️
OS-macOS 86.22% <100.00%> (+0.03%) ⬆️
Py-3.11 99.90% <100.00%> (ø)
Py-3.12 99.90% <100.00%> (ø)
test-functional 86.45% <100.00%> (+0.03%) ⬆️
test-unit 84.08% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@francis-clairicia francis-clairicia merged commit 68fc10c into main Dec 2, 2023
19 checks passed
@francis-clairicia francis-clairicia deleted the hotfix/async/async-socket-close-errno branch December 2, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@francis-clairicia francis-clairicia

Labels
bug Something isn't working topic-async Relative to asynchronous API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@francis-clairicia