Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BufferedStreamProtocol object #302

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

francis-clairicia
Copy link
Owner

What's changed

BufferedStreamProtocol must be used to explictly exploit BufferedIncrementalPacketSerializer interface

Backward incompatible changes

  • Removed manual_buffer_allocation parameter from existing API
  • Removed BufferedStreamReceiver class.
  • Removed StreamProtocol.buffered_receiver() method.

@francis-clairicia francis-clairicia added enhancement New feature or request topic-async Relative to asynchronous API topic-sync Relative to synchronous API topic-serializer Relative to serializer implementations breaking-changes Backward-incompatible changes labels Jun 22, 2024
@francis-clairicia francis-clairicia self-assigned this Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4a2f97) to head (8ea278e).
Report is 65 commits behind head on main.

Additional details and impacted files
Flag Coverage Δ
OS-Linux 99.87% <100.00%> (-0.01%) ⬇️
OS-Windows 99.75% <100.00%> (-0.01%) ⬇️
OS-macOS 99.87% <100.00%> (-0.01%) ⬇️
Py-3.11 99.84% <100.00%> (-0.01%) ⬇️
Py-3.12 99.74% <100.00%> (-0.01%) ⬇️
test-functional 82.53% <76.54%> (+0.38%) ⬆️
test-unit 88.91% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francis-clairicia francis-clairicia merged commit f4602de into main Jun 22, 2024
22 checks passed
@francis-clairicia francis-clairicia deleted the feature/buffered-stream-protocol branch June 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes Backward-incompatible changes enhancement New feature or request topic-async Relative to asynchronous API topic-serializer Relative to serializer implementations topic-sync Relative to synchronous API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant