Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed BufferedStreamReadTransport class #308

Merged

Conversation

francis-clairicia
Copy link
Owner

What's changed

  • Removed easynetwork.lowlevel.api_async.transports.abc.AsyncBufferedStreamReadTransport
    • AsyncStreamReadTransport now have recv_into() abstract method
    • AsyncStreamReadTransport.recv() now have a default implementation that uses recv_into()
  • Removed easynetwork.lowlevel.api_sync.transports.abc.BufferedStreamReadTransport
    • StreamReadTransport now have recv_into() abstract method
    • StreamReadTransport.recv() now have a default implementation that uses recv_into()
  • Removed easynetwork.lowlevel.api_sync.transports.base_selector.SelectorBufferedStreamReadTransport
    • SelectorStreamReadTransport now have recv_noblock_into() abstract method
    • SelectorStreamReadTransport.recv_noblock() now have a default implementation that uses recv_noblock_into()

@francis-clairicia francis-clairicia added topic-client Relative to client implementations topic-server Relative to server implementations topic-async Relative to asynchronous API topic-sync Relative to synchronous API breaking-changes Backward-incompatible changes labels Jun 26, 2024
@francis-clairicia francis-clairicia self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9a2f17) to head (1361b85).

Additional details and impacted files
Flag Coverage Δ
OS-Linux 99.87% <100.00%> (-0.01%) ⬇️
OS-Windows 99.75% <100.00%> (-0.01%) ⬇️
OS-macOS 99.87% <100.00%> (-0.01%) ⬇️
Py-3.11 99.84% <100.00%> (-0.01%) ⬇️
Py-3.12 99.74% <100.00%> (-0.01%) ⬇️
test-functional 82.35% <42.55%> (-0.18%) ⬇️
test-unit 88.98% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francis-clairicia francis-clairicia merged commit 9919406 into main Jun 26, 2024
22 checks passed
@francis-clairicia francis-clairicia deleted the fix/lowlevel-api/remove-buffered-stream-read-transport branch June 26, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes Backward-incompatible changes topic-async Relative to asynchronous API topic-client Relative to client implementations topic-server Relative to server implementations topic-sync Relative to synchronous API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant