Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS transport: Fixed SSL object consistency errors when sending data and closing the object #309

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

francis-clairicia
Copy link
Owner

@francis-clairicia francis-clairicia commented Jun 27, 2024

  • Fixed send_all() ignoring number of data written to SSL object
  • Erase SSL errors raised by ssl_object.shutdown()
  • Fix double-close issue

@francis-clairicia francis-clairicia added bug Something isn't working topic-async Relative to asynchronous API labels Jun 27, 2024
@francis-clairicia francis-clairicia self-assigned this Jun 27, 2024
@francis-clairicia francis-clairicia changed the title TLS transport: Fixed send_all() ignoring number of data written to SSL object TLS transport: Fixed send_all() ignoring number of data written to SSL object Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9919406) to head (7c5f2f6).
Report is 58 commits behind head on main.

Additional details and impacted files
Flag Coverage Δ
OS-Linux 99.87% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.75% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.87% <100.00%> (+<0.01%) ⬆️
Py-3.11 99.84% <100.00%> (+<0.01%) ⬆️
Py-3.12 99.74% <100.00%> (+<0.01%) ⬆️
test-functional 82.27% <76.08%> (-0.08%) ⬇️
test-unit 88.99% <91.30%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francis-clairicia francis-clairicia changed the title TLS transport: Fixed send_all() ignoring number of data written to SSL object TLS transport: Fixed SSL object consistency errors when sending data and closing the object Jun 27, 2024
@francis-clairicia francis-clairicia merged commit dc4b669 into main Jun 27, 2024
22 checks passed
@francis-clairicia francis-clairicia deleted the fix/lowlevel-api/tls-transport branch June 27, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic-async Relative to asynchronous API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant