Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsyncBackend.run_in_thread(): Removed **kwargs and added abandon_on_cancel #331

Merged

Conversation

francis-clairicia
Copy link
Owner

What's changed

  • It is no longer possible to call run_in_thread() with variadic keyword arguments
  • Added keyword-only parameter abandon_on_cancel to permit task cancellation.

@francis-clairicia francis-clairicia added topic-async Relative to asynchronous API breaking-changes Backward-incompatible changes labels Jul 25, 2024
@francis-clairicia francis-clairicia self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (11bd710) to head (c90039c).
Report is 60 commits behind head on main.

Additional details and impacted files
Flag Coverage Δ
OS-Linux 99.90% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.78% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.90% <100.00%> (+<0.01%) ⬆️
Py-3.11 99.90% <100.00%> (+<0.01%) ⬆️
Py-3.12 99.94% <100.00%> (+<0.01%) ⬆️
test-functional 81.76% <100.00%> (+<0.01%) ⬆️
test-unit 89.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@francis-clairicia francis-clairicia merged commit a15d0d8 into main Jul 25, 2024
22 checks passed
@francis-clairicia francis-clairicia deleted the fix/async-backend/remove-run-in-thread-kwargs branch July 25, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes Backward-incompatible changes topic-async Relative to asynchronous API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant