Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set engine options that change value #82

Conversation

franciscoBSalgueiro
Copy link
Owner

No description provided.

@franciscoBSalgueiro franciscoBSalgueiro linked an issue Nov 11, 2023 that may be closed by this pull request
@franciscoBSalgueiro franciscoBSalgueiro merged commit f1896a7 into master Nov 11, 2023
2 checks passed
@franciscoBSalgueiro franciscoBSalgueiro deleted the 81-engine-options-are-sent-every-time-even-if-they-dont-change branch November 11, 2023 00:44
@harshil21
Copy link

Does this fix the issue where the engine re-evaluates the position when I go back one move? I'd like en croissant to "remember" the best moves. Apparently this feature is called as "persistent hashing"? As an example, I was using https://github.com/fitztrev/lichess-tauri before this and on the lichess.org analysis page, the engine/lichess "remembered" the best moves without recalculating every time I went back one move.

@dav1312
Copy link
Contributor

dav1312 commented Nov 13, 2023

Does this fix the issue where the engine re-evaluates the position when I go back one move? I'd like en croissant to "remember" the best moves. Apparently this feature is called as "persistent hashing"? As an example, I was using fitztrev/lichess-tauri before this and on the lichess.org analysis page, the engine/lichess "remembered" the best moves without recalculating every time I went back one move.

It should for engines like Stockfish because setting the number of threads cleares the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine options are sent every time even if they don't change
3 participants