Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source of truth for versiontag #4

Open
franiglesias opened this issue Jul 29, 2018 · 6 comments
Open

Source of truth for versiontag #4

franiglesias opened this issue Jul 29, 2018 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@franiglesias
Copy link
Owner

Given since 1.4.1 we support writing of .semver file, I'm thinking what source of truth should we use to detect last version.

  • Use git tag (the current option)
  • Use the .semver file
  • Look for tags in remote
@franiglesias franiglesias added enhancement New feature or request help wanted Extra attention is needed labels Jul 29, 2018
@pkristian
Copy link
Collaborator

i am thinging about something like git tag -l | sort | grep

@franiglesias
Copy link
Owner Author

A critical thing here is to ensure we access to the last tag. For tagging, at my job, we usually perform a git pull --tags to bring tags in the shared repose we can look for the last and then tag last commit as required.

@pkristian
Copy link
Collaborator

pkristian commented Jul 31, 2018

i am thinking about it.. but i have a few questions:

  1. are we considering and making only stable versions (v1.2.3) or even unstable? (v1.2.3-RC3) See Suffixed versions #7
  2. what about different sets of versions: for example there is one package in more versions lets say:
  3. sometimes pull dont have to be best option. i mean, i thnk it fill be nice to vanilla command to do less stuff. because when tool become too much opinioned, you are enforcing one use case.

idea: getting tags from git list, this way you will:

  • get lattest version pretty easy
  • allow multiple versions

@franiglesias
Copy link
Owner Author

I've created some new issues to better discuss this questions. See #7 and #8

@franiglesias
Copy link
Owner Author

franiglesias commented Jul 31, 2018

I'm experimenting with this snippet to get the latest version from tags. A good thing is that It allows to discriminate between version tagging and other types of tags. I think it needs better sorting.

git tag | sort -r | grep "^v[0-9]*\.[0-9]*\.[0-9]" | head -1

@franiglesias
Copy link
Owner Author

sometimes pull dont have to be best option. i mean, i thnk it fill be nice to vanilla command to do less stuff. because when tool become too much opinioned, you are enforcing one use case.

Yes. I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants