RS-1136: Do not impede logging to stdout

franklin-ai · Jun 15, 2023 · 1432c79 · 1432c79
2 parents bef70ab + eb5c05a
commit 1432c79
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 32 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "ros_logger"
-version = "0.1.2"
+version = "0.1.4"
 description = """
 A logging implementation for `log` which is configured via an environment
 variable and creates tracing events for opentelemetry subscribers to subscribe to.

diff --git a/src/lib.rs b/src/lib.rs
@@ -907,36 +907,17 @@ impl Log for Logger {
 
     fn log(&self, record: &Record) {
         let max_packet_size = 65000;
-        let message = format!("{:#?}", record.args());
-
-        if self.matches(record) && message.as_bytes().len() < max_packet_size {
-            match record.level() {
-                Level::Error => tracing::event!(
-                    tracing::Level::ERROR,
-                    target = record.target(),
-                    message = format!("{:#?}", record.args())
-                ),
-
-                Level::Warn => tracing::event!(
-                    tracing::Level::WARN,
-                    target = record.target(),
-                    message = format!("{:#?}", record.args())
-                ),
-                Level::Info => tracing::event!(
-                    tracing::Level::INFO,
-                    target = record.target(),
-                    message = format!("{:#?}", record.args())
-                ),
-                Level::Debug => tracing::event!(
-                    tracing::Level::DEBUG,
-                    target = record.target(),
-                    message = format!("{:#?}", record.args())
-                ),
-                Level::Trace => tracing::event!(
-                    tracing::Level::TRACE,
-                    target = record.target(),
-                    message = format!("{:#?}", record.args())
-                ),
+
+        if self.matches(record) {
+            let message = format!("{:#?}", record.args());
+            if message.as_bytes().len() < max_packet_size {
+                match record.level() {
+                    Level::Error => tracing::error!(message),
+                    Level::Warn => tracing::warn!(message),
+                    Level::Info => tracing::info!(message),
+                    Level::Debug => tracing::debug!(message),
+                    Level::Trace => tracing::trace!(message),
+                }
             }
 
             // Log records are written to a thread-local buffer before being printed