Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor naming #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor naming #44

wants to merge 4 commits into from

Conversation

Revazashvili
Copy link

@Revazashvili Revazashvili commented Dec 2, 2024 •
edited
Loading

  1. private readonly members should start with lowercase
  2. constants should start with uppercase
  3. local variable naming was inconsistent
  4. fixed tests where private field was retrieved, btw I don't think it's roght to do

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Clifftech123
Copy link
Collaborator

@Revazashvili Thank you for this. It will be reviewed. Thank you for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Revazashvili @Clifftech123