fix: purchase return validation issue (backport #43871) (backport #43874) #43879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
fix: purchase return validation issue (#43871) (cherry picked from commit a7cc7b2) Co-authored-by: rohitwaghchaure <[email protected]> (cherry picked from commit b4d4c4a)
mergify
bot
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
# [15.40.0](v15.39.6...v15.40.0) (2024-10-30) ### Bug Fixes * add company filter for project ([33fa1e4](33fa1e4)) * add parenttype clause to invoice tax query in sales_register report ([603d2cf](603d2cf)) * backport translations from develop ([#43849](#43849)) ([11dd196](11dd196)) * basic rate not editable in Stock Entry Detail (backport [#43837](#43837)) ([#43838](#43838)) ([20478b6](20478b6)) * better implementation, handle missing purchase order ([41db040](41db040)) * Calculate gross margin on update of project costing from invoices (backport [#43876](#43876)) ([#43900](#43900)) ([93d0db2](93d0db2)) * calculate tds with net amount when invoice exceeds single threshold amount (backport [#43869](#43869)) ([#43920](#43920)) ([9a52661](9a52661)) * cannot create opp from lead without prospect ([4dcaf42](4dcaf42)) * consider gle based on balances in company currency ([#43805](#43805)) ([2fb4417](2fb4417)) * consider opening asset values while calculating asset depreciation rate ([1af2326](1af2326)) * correct garbage value on Razorpay Payments Page ([2c21df2](2c21df2)) * do not check for payment terms details for return invoices. ([9a5604c](9a5604c)) * do not copy serial numbers from DN to SI (backport [#43885](#43885)) ([#43893](#43893)) ([d06831e](d06831e)) * do not set payment terms for return invoices ([a826a89](a826a89)) * find first PCV to consider opening entries ([8218ca9](8218ca9)) * Handle None value for item description in customer portal invoice view (backport [#43823](#43823)) ([#43889](#43889)) ([8a72845](8a72845)) * hide payment terms for return and paid purchase invoices ([29aa5d6](29aa5d6)) * incorrect value of available_qty_for_consumption in subcontracti… (backport [#43836](#43836)) ([#43861](#43861)) ([cd4746a](cd4746a)) * map doc from purchase order ([58a3ef7](58a3ef7)) * Patch for reposting account closing balance (backport [#43905](#43905)) ([#43910](#43910)) ([ab16207](ab16207)) * post account closing balance against pcv closing account (backport [#43887](#43887)) ([#43898](#43898)) ([e22d0a3](e22d0a3)) * purchase return validation issue (backport [#43871](#43871)) (backport [#43874](#43874)) ([#43879](#43879)) ([db3be41](db3be41)) * recalculate outstanding after save on checkout for POS Invoice ([63668eb](63668eb)) * remarks field in payment reconciliation ([8707090](8707090)) * **RFQ:** make strings translatable (backport [#43843](#43843)) ([#43848](#43848)) ([07aaef2](07aaef2)) * rounding issue of required qty in subcontracting order ([#43908](#43908)) ([9ac87bd](9ac87bd)) * scrub "-" from fieldname in accounting dimension ([c702826](c702826)) * set bill_no before `against_voucher` gets concatenated ([81297ce](81297ce)) * set default warehouse for pos invoice ([b80a5f2](b80a5f2)) * set proper currency format ([9f97018](9f97018)) * Unnecessary validation for non deferred sales invoices ([#43816](#43816)) ([bf4fb53](bf4fb53)) * use period closing voucher object to call get_account_closing_ba… (backport [#43880](#43880)) ([#43883](#43883)) ([8bfc212](8bfc212)) * validate fieldname ([b21abf4](b21abf4)) * work order finish button not showing (backport [#43875](#43875)) (backport [#43877](#43877)) ([#43904](#43904)) ([7189dab](7189dab)) ### Features * add party name in payment request ([935f2e1](935f2e1)) ### Performance Improvements * performance optimizations for accounting reports by refactoring account closing balance and period closing voucher ([#43798](#43798)) ([ced76ca](ced76ca))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #43871 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #43874 done by [Mergify](https://mergify.com).