feat: added ability to use custom html format for process statement of accounts #45746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of accounts documents.
stevewilson9009
requested review from
deepeshgarg007 and
ruthra-kumar
as code owners
stevewilson9009
changed the title
stevewilson9009
changed the title
|
|
||
| process_soa_html = frappe.get_hooks("process_soa_html") | ||
| # fetching custom print format of Process Statement of Accounts | ||
| if process_soa_html.get(doc.report): |
There was a problem hiding this comment.
when not set, frappe.get_hooks returns an empty list. Using get on list will throw error. You'll have to handle non-existing hook case as well.
There was a problem hiding this comment.
@ruthra-kumar
Thankyou for pointing that out.
I have updated the code to check for non-existing hook as well.
There was a problem hiding this comment.
|
Could you please review my code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to process_statement_of_accounts.py.
The added code accepts the path to a custom html format of General Ledger and Accounts Receivable through a hook.
This path to custom html format is then used to build pdf to either download or send email.