fix: added validation for required invoice_fields in POS #45780
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
approved these changes
Feb 11, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
fix: added missing validation for required invoice_fields (cherry picked from commit b95b13e) # Conflicts: # erpnext/selling/page/point_of_sale/pos_payment.js
diptanilsaha
added a commit
that referenced
this pull request
Feb 11, 2025
…5780) (#45868) * fix: added validation for required invoice_fields in POS (#45780) fix: added missing validation for required invoice_fields (cherry picked from commit b95b13e) # Conflicts: # erpnext/selling/page/point_of_sale/pos_payment.js * fix: resolved merge conflict --------- Co-authored-by: Diptanil Saha <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
# [15.52.0](v15.51.2...v15.52.0) (2025-02-12) ### Bug Fixes * '0' rate LDC's Invoice net totals should be ignored ([96c19cd](96c19cd)) * add allow_on_submit for party_balance, paid_from_account_balance and paid_to_account_balance ([086c36f](086c36f)) * add precision in serial_batch_bundle.py ([a85f6f5](a85f6f5)) * add total row in non_grouped_invoices ([e432ae9](e432ae9)) * added validation for required invoice_fields in POS (backport [#45780](#45780)) ([#45868](#45868)) ([4f9a7f5](4f9a7f5)) * Attibute error `selling_price_list` ([6dc99f9](6dc99f9)) * changed naming series to random for SABB ([48a4eff](48a4eff)) * check_item_quality_inspection is not whitelisted ([0a4a093](0a4a093)) * correct amount in transaction currency for reverse gl entries (backport [#45794](#45794)) ([#45849](#45849)) ([b06bd82](b06bd82)) * correct amt in account currency for lcv with manually distributed charges. (backport [#45532](#45532)) ([#45864](#45864)) ([179cb1e](179cb1e)) * correct pay amount in portal pages ([3ada520](3ada520)) * create job card with wip warehouse set to source warehouse if material transfer to wip warehouse is skipped in work order ([9d6f318](9d6f318)) * do not allow "Finance Book" in Accounting Dimensions (backport [#45696](#45696)) ([#45856](#45856)) ([0954aca](0954aca)) * do not validate party against Receivable and Payable account for cancelled gl entries ([6d777cd](6d777cd)) * dont update rate of free item on save ([1d3da4d](1d3da4d)) * handle response when json is None ([eeb322b](eeb322b)) * map project from rfq to supplier quotation (backport [#45745](#45745)) ([#45828](#45828)) ([b112d88](b112d88)) * not able to select the item in the sales invoice ([a649001](a649001)) * Party name in Supplier Portal for Purchase Order (backport [#45772](#45772)) ([#45858](#45858)) ([435c354](435c354)) * pos numpad editable action buttons (backport [#45823](#45823)) ([#45826](#45826)) ([035758f](035758f)) * possible model sync issue ([ea01fa1](ea01fa1)) * **regional:** removed payment schedule validation in sales invoice for italy (backport [#45852](#45852)) ([#45854](#45854)) ([2e9e355](2e9e355)) * remove serial no if qty is zero ([1359a77](1359a77)) * skip warning for free items ([2adab1d](2adab1d)) * stock reco current valuation rate ([3b7c38d](3b7c38d)) * the project document timed out while opening ([28cbce4](28cbce4)) * unable to remove image from employee ([e3cceb8](e3cceb8)) * update ctx to args ([d4bc3d1](d4bc3d1)) ### Features * add repost accounting ledger entry for payment entry ([757dd3f](757dd3f))
diptanilsaha
added a commit
to diptanilsaha/erpnext
that referenced
this pull request
Feb 14, 2025
fix: added missing validation for required invoice_fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation for required invoice_fields in POS.
Before:
Screen.Recording.2025-02-07.at.12.37.55.PM.mov
After:
Screen.Recording.2025-02-07.at.12.39.29.PM.mov