fix: skip warning for free items #45786
Merged
+10
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our use case: we have a free item on the Delivery Note and also want that same free item on the mapped Sales Invoice.
For 0-amount line items we used to get the following warning: "System will not check over billing since amount for Item {item_code} in Delivery Note is zero."
Some users just get confused by this warning and stop working on the document, while there's nothing wrong with it.
Hence, I propose to silently skip overbilling checks for free items (0-amount on ref-doc and 0-amount on current doc).
Internal ref: LAN-868