Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip warning for free items #45786

Merged

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Feb 7, 2025

Our use case: we have a free item on the Delivery Note and also want that same free item on the mapped Sales Invoice.

For 0-amount line items we used to get the following warning: "System will not check over billing since amount for Item {item_code} in Delivery Note is zero."

Some users just get confused by this warning and stop working on the document, while there's nothing wrong with it.

Hence, I propose to silently skip overbilling checks for free items (0-amount on ref-doc and 0-amount on current doc).

Internal ref: LAN-868

@barredterra barredterra force-pushed the skip-warning-for-free-items branch from 274de67 to 772776a Compare February 7, 2025 10:43
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Feb 7, 2025
@miteshpc
Copy link

miteshpc commented Feb 8, 2025

This can also happen when a newly added item without an item price is added by the sales invoice user. Shouldn't there be an override at the line item level to avoid stock reduction by user error at 0 revenue, resulting into unexpected profits showing up at the cost of COGS.

Some kind of control is needed instead of letting 0 rate items gone unnoticed.

@ruthra-kumar ruthra-kumar self-assigned this Feb 10, 2025
@rohitwaghchaure rohitwaghchaure merged commit 5f554e1 into frappe:develop Feb 12, 2025
13 checks passed
@barredterra barredterra deleted the skip-warning-for-free-items branch February 12, 2025 09:30
rohitwaghchaure added a commit that referenced this pull request Feb 12, 2025
…-45786

fix: skip warning for free items (backport #45786)
rohitwaghchaure added a commit that referenced this pull request Feb 12, 2025
…-45786

fix: skip warning for free items (backport #45786)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants