Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: misc changes #681

Merged
merged 3 commits into from
Nov 22, 2023
Merged

feat: misc changes #681

merged 3 commits into from
Nov 22, 2023

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Nov 21, 2023 •
edited
Loading

  1. Now when a moderator gets tagged in a discussion they will receive an email informing them about the same.
Screenshot 2023-11-22 at 2 30 22 PM
  1. In LMS Payments doctype you can now add website users as members too.
  2. Fixed quiz working from submission page.

@cypress Cypress
Copy link

cypress bot commented Nov 21, 2023 •
edited
Loading

Passing run #382 ↗︎

0 1 0 0 Flakiness 0

Details:

Merge 6f40c35 into be4e3aa...
Project: lms Commit: c117b2f9bb ℹ️
Status: Passed Duration: 00:43 💡
Started: Nov 22, 2023 12:00 PM Ended: Nov 22, 2023 12:01 PM

Review all test suite changes for PR #681 ↗︎

@pateljannat pateljannat marked this pull request as draft November 21, 2023 09:01
@pateljannat pateljannat marked this pull request as ready for review November 22, 2023 11:25
@pateljannat pateljannat changed the title feat: discussions mention notifications feat: misc changes Nov 22, 2023
@pateljannat pateljannat merged commit 479be0b into frappe:main Nov 22, 2023
3 checks passed
@pateljannat pateljannat mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pateljannat