-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to record performance report of database #1395
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
- Coverage 37.36% 36.54% -0.82%
==========================================
Files 349 398 +49
Lines 29398 30861 +1463
==========================================
+ Hits 10984 11278 +294
- Misses 18414 19583 +1169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@tanmoysrt awesome stuff! I've some queries and suggestions.
|
cc @ankush |
After getting some more context on the perf schema, understood that we don't need all the information actually. Let's continue the discussion here - #2361 (comment) |
Closing this PR. |
Related #723
Required agent PR frappe/agent#129
Changes -
fetch_performance_report
method inDatabase Server
doctypePerformance Report
doctype which will contain performance schema reportsPerformance Report
Preview
2024-02-04.10-29-39.mp4