Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: database user and permission manager #2245

Merged
merged 39 commits into from
Nov 25, 2024

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Oct 31, 2024

Fixes #2237

Agent PR - frappe/agent#142

Preview -

db-perm-demo-1.mp4

Granular Permission test -

db-perm-demo-2.mp4

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 22.43902% with 159 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (21a3f76) to head (c977ed7).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...s/doctype/site_database_user/site_database_user.py 21.71% 137 Missing ⚠️
press/agent.py 33.33% 10 Missing ⚠️
press/press/doctype/agent_job/agent_job.py 22.22% 7 Missing ⚠️
...table_permission/site_database_table_permission.py 0.00% 4 Missing ⚠️
...press/doctype/agent_job/agent_job_notifications.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   39.79%   39.66%   -0.13%     
==========================================
  Files         373      375       +2     
  Lines       28386    28586     +200     
==========================================
+ Hits        11296    11340      +44     
- Misses      17090    17246     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

…low completed for read-only, read-write mode completed
@tanmoysrt tanmoysrt marked this pull request as ready for review November 11, 2024 03:50
@tanmoysrt tanmoysrt marked this pull request as draft November 11, 2024 03:50
@tanmoysrt tanmoysrt marked this pull request as ready for review November 23, 2024 08:16
@tanmoysrt
Copy link
Member Author

Failed tests are not related to this

  • test_creation_of_db_server_adds_default_mariadb_variables
  • test_site_update_callback_reallocates_workers_after_disable_maintenance_mode_job

@tanmoysrt tanmoysrt merged commit 04ee6c5 into frappe:master Nov 25, 2024
2 of 4 checks passed
@tanmoysrt tanmoysrt deleted the db_user_permission_manager branch November 25, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: db users and permission manager
1 participant