Remove WP installers with profile.d #3
Conversation
josepfrantic
force-pushed
the
frc
branch
2 times, most recently
from
0293467 to
9757004
Compare
|
Seems like an good idea, but have you tested does this cause any other issues, in normal operations? Removing files seems a bit brutal; how nicely does WP fallback from that? Are there any sites where this has been tested? |
|
All of these should fail within Heroku anyway because a) they can't write to disk b) even if they could, it would be reverted when dyno restarts. Has been tested and running on a production site for 30 days without any issues. |
|
We talked with Lauri about this, and there might be a problem when wp database update is needed when wp is updated. I have to look into it a bit more |
| @@ -0,0 +1,5 @@ | |||
| rm -rf $HOME/web/wp/wp-admin/install.php | |||
There was a problem hiding this comment.
This is not going to work in wp-bedrock-seed projects.
$HOME is /app in heroku but the actual filepath would be ./bedrock-on-heroku/web/wp/wp-admin/install.php
Since this is a bash script anyway, we could check if the directory "bedrock-on-heroku" exists, in order to know the right location to remove those files.
There was a problem hiding this comment.
Or rm -rf both locations, other will fail silently?
No description provided.