Skip to content

Commit

Permalink
mobile: Mark AndroidEngineExplicitFlowTest as flaky (envoyproxy#36426)
Browse files Browse the repository at this point in the history
The `AndroidEngineExplicitFlowTest.post_multipleRequests_randomBehavior`
seems to be the one that's causing the flakiness. Adding `flaky = True`
and fixing the HTTP method to `POST` as what the test is intended seemed
to reduce the flakiness.

Risk Level: low (test only)
Testing: `bazel test --runs_per_test=100
//test/java/integration:android_engine_explicit_flow_test`
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Fredy Wijaya <[email protected]>
  • Loading branch information
fredyw authored Oct 2, 2024
1 parent 8c635c4 commit dc35c85
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,8 @@ public void post_multipleRequests_randomBehavior() throws Exception {
mockWebServer.enqueue(new MockResponse().setBody("hello, world"));
RequestScenario requestScenario =
new RequestScenario()
.setHttpMethod(RequestMethod.GET)
.setUrl(mockWebServer.url("get/flowers").toString())
.setHttpMethod(RequestMethod.POST)
.setUrl(mockWebServer.url("post/flowers").toString())
.addBody("This is my body part 1")
.addBody("This is my body part 2")
.setResponseBufferSize(20); // Larger than the response body size
Expand Down
1 change: 1 addition & 0 deletions mobile/test/java/integration/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ envoy_mobile_android_test(
srcs = [
"AndroidEngineExplicitFlowTest.java",
],
flaky = True,
native_deps = [
"//test/jni:libenvoy_jni_with_test_extensions.so",
] + select({
Expand Down

0 comments on commit dc35c85

Please sign in to comment.