Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create twitch proxy tests #617

Merged

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Sep 25, 2024

Checklist:

Related to #490

This adds a few tests to ensure the Twitch Proxy data routes are still functioning correctly.

@a2937 a2937 requested a review from a team as a code owner September 25, 2024 21:42
@a2937
Copy link
Member Author

a2937 commented Sep 26, 2024

I don't understand. What's different between my local project and the one being hosted here.

image

This is the data I expect in the API.

{"data":[{"id":"79776140","login":"freecodecamp","display_name":"FreeCodeCamp","type":"","broadcaster_type":"","description":"Learn to code for free at freecodecamp.org","profile_image_url":"https://static-cdn.jtvnw.net/jtv_user_pictures/freecodecamp-profile_image-d9514f2df0962329-300x300.png","offline_image_url":"https://static-cdn.jtvnw.net/jtv_user_pictures/freecodecamp-channel_offline_image-b8e133c78cd51cb0-1920x1080.png","view_count":0,"created_at":"2015-01-14T03:36:47Z"}]}

@a2937
Copy link
Member Author

a2937 commented Oct 22, 2024

I need to see what exactly the results are from the workflow cause while it returns 200,something isn't matching up with my computer.

@a2937
Copy link
Member Author

a2937 commented Oct 22, 2024

{ error: 'Unauthorized', status: 401, message: 'Invalid OAuth token' }

Oh so that's why. The updateApiKey function is kaput. Well I guess I can try go past it and see what happens. Worst comes to worst I formalize the helix API.

@ShaunSHamilton
Copy link
Member

I thought I was being smart making those changes. It works locally, but apparently not in CI, and I have no idea what that error is saying.

@ShaunSHamilton ShaunSHamilton self-assigned this Oct 24, 2024
test/jest-utils.js Outdated Show resolved Hide resolved
Co-authored-by: Oliver Eyton-Williams <[email protected]>
Copy link
Member

@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @a2937

Copy link
Contributor

@ojeytonwilliams ojeytonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers, @a2937 this LGTM 👍

@ojeytonwilliams ojeytonwilliams merged commit 5be11a9 into freeCodeCamp:main Oct 24, 2024
2 checks passed
@a2937 a2937 deleted the chore/create-twitch-proxy-tests branch October 24, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants