Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure S3 as upload provider #439

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sidemt
Copy link
Member

@sidemt sidemt commented Feb 12, 2024

Checklist:

Closes #52

I tested uploading and retrieving images with my personal AWS account. This config should work if the permissions on the AWS S3 are configured properly.

The URL() constructor is smart enough to use the second argument (base URL) only if the first argument is a relative path. So the frontend app works for both development (using local disk) and production (using S3) without any changes.

image

image

Copy link

socket-security bot commented Feb 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@strapi/[email protected] Transitive: environment, filesystem, network, shell +105 6.19 MB markkaylor

View full report↗︎

@sidemt sidemt marked this pull request as ready for review February 13, 2024 14:23
@sidemt sidemt requested a review from a team as a code owner February 13, 2024 14:23
@raisedadead
Copy link
Member

... config should work if the permissions on the AWS S3 are configured properly.

Please point me to the bucket policy, IAM role etc. that I need to configure. Thanks

@sidemt
Copy link
Member Author

sidemt commented Feb 13, 2024

@raisedadead Sure, I will document and share them with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image hosting
2 participants