feat: use standardised callouts #679
Open
+151
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know @huyenltnguyen you will have thoughts about this, please feel free to push changes if you prefer. But my intent here is to standardize the callouts we have been using in the main platform. All those notes look ugly as heck. LMK what you think. |
huyenltnguyen
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Thanks for the improvements, Mrugesh!
I like the changes here. They should distinguish Alert and Callout and prevent misuses.
We're renaming the variants so this is a breaking change. Since we already have another potential breaking change (#665), if you don't mind, I'd like to hold this off a bit until I can merge and release the breaking changes together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.