Skip to content
This repository has been archived by the owner on Apr 1, 2021. It is now read-only.

updated merge-sort #1086

Merged
merged 4 commits into from
Jun 5, 2016
Merged

updated merge-sort #1086

merged 4 commits into from
Jun 5, 2016

Conversation

jainaman224
Copy link
Contributor

@ghost ghost self-assigned this Jun 4, 2016
@ghost ghost added this to the June Summit milestone Jun 4, 2016
@@ -2,7 +2,7 @@

Most modern languages have an inbuilt sort() function which automatically sorts an input array or list. Did you ever wonder how the sort function actually works on the inside?. Knowing common sorting algorithms and their implementations is the most important part of a coding interview. In this series of articles, we will look at several important sorting algorithms. How they are implemented, the time and space complexity etc. Our very first post is on Merge Sort.

##
##
Copy link
Member

@Rafase282 Rafase282 Jun 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-##
+##  

we need the two spaces next to ##

so it will look like this:

instead of this:

With the space it is not visible but still does the job for the chat.

@Rafase282 Rafase282 self-assigned this Jun 4, 2016
@ghost
Copy link

ghost commented Jun 4, 2016

LGTM 👍

@@ -13,36 +13,124 @@ To learn about Merge Sort, a basic knowledge about [Recursion](http://programmer
The biggest advantage of using Merge sort is that the [time complexity](https://www.youtube.com/watch?v=V42FBiohc6c&list=PL2_aWCzGMAwI9HK8YPVBjElbLbI3ufctn) is only n*log(n) to sort an entire Array. It is a lot better than n^2 running time of bubble sort or insertion sort.
Before we write the JavaScript code, let us understand how merge sort works with the help of a diagram.

![alt tag] (https://i67.tinypic.com/2ahe49y.png)
![Merge Sort] (https://i67.tinypic.com/2ahe49y.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-![Merge Sort] (https://i67.tinypic.com/2ahe49y.png)
+![Merge Sort](https://i67.tinypic.com/2ahe49y.png)

@@ -13,36 +13,124 @@ To learn about Merge Sort, a basic knowledge about [Recursion](http://programmer
The biggest advantage of using Merge sort is that the [time complexity](https://www.youtube.com/watch?v=V42FBiohc6c&list=PL2_aWCzGMAwI9HK8YPVBjElbLbI3ufctn) is only n*log(n) to sort an entire Array. It is a lot better than n^2 running time of bubble sort or insertion sort.
Before we write the JavaScript code, let us understand how merge sort works with the help of a diagram.

![alt tag] (https://i67.tinypic.com/2ahe49y.png)
![Merge Sort](https://i67.tinypic.com/2ahe49y.png)
Copy link
Member

@Rafase282 Rafase282 Jun 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the link to https://i.imgur.com/ac98ccu.png

That link is not working, I uploaded the image to the one I just posted.

-![Merge Sort](https://i67.tinypic.com/2ahe49y.png)
+![Merge Sort](https://i.imgur.com/ac98ccu.png)

Merge Sort

@Rafase282 Rafase282 merged commit d75c845 into freeCodeCamp:master Jun 5, 2016
@BerkeleyTrue BerkeleyTrue removed the QA label Jun 5, 2016
@Rafase282
Copy link
Member

Thanks @jainaman224

@jainaman224 jainaman224 deleted the merge-sort branch June 5, 2016 15:41
@alayek alayek mentioned this pull request Jun 5, 2016
26 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants