devinfo: Use strlcpy and correct allocation size

freebsd · Oct 20, 2024 · 5aa5e86 · 5aa5e86
1 parent 0f668e6
commit 5aa5e86
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/usr.sbin/devinfo/devinfo.c b/usr.sbin/devinfo/devinfo.c
@@ -121,13 +121,15 @@ print_resource(struct devinfo_res *res)
 	bool			hexmode;
 	rman_res_t		end;
 	char			*safe_desc;
+	size_t			len;
 
 	rman = devinfo_handle_to_rman(res->dr_rman);
 	hexmode =  (rman->dm_size > 1000) || (rman->dm_size == 0);
 	end = res->dr_start + res->dr_size - 1;
 
-	safe_desc = malloc(strlen(rman->dm_desc));
-	strcpy(safe_desc, rman->dm_desc);
+	len = strlen(rman->dm_desc) + 1;
+	safe_desc = malloc(len);
+	strlcpy(safe_desc, rman->dm_desc, len);
 	xml_safe_string(safe_desc);
 
 	xo_open_instance(safe_desc);