Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOMERGE] Test an auto-request-review github action #1180

Closed
wants to merge 1 commit into from
Closed

[NOMERGE] Test an auto-request-review github action #1180

wants to merge 1 commit into from

Conversation

zxombie
Copy link
Member

@zxombie zxombie commented Apr 17, 2024

Don't merge, testing an action to add developers to GitHub reviews

@zxombie zxombie force-pushed the gh-auto-review branch 3 times, most recently from fa497a8 to e7fc02c Compare April 17, 2024 19:31
@zxombie
Copy link
Member Author

zxombie commented Apr 17, 2024

It looks like the default public repo secrets.GITHUB_TOKEN is read-only. For this to work we would need to use pull_request_target. This only works on the base commit, i.e. something already in git. This is for security reasons as the token will have read/write access.

@zxombie zxombie closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zxombie