Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ->*_handlers fields #1357

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Remove ->*_handlers fields #1357

wants to merge 7 commits into from

Commits on Nov 6, 2024

  1. tegra: remove duplicate enabling/disabling of interrupts 

    INTRNG will call the enable/disable functions immediately after the
first handler is added, or the last is removed.  As a result there is no
need for setup/teardown functions to handle this task.

The teardown functions were doing nothing else.  Remove the PCIe
teardown function, the GPIO teardown function can be repurposed.  The
PCIe setup function might still have some value in a debugging kernel.
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c9af466 View commit details
    Browse the repository at this point in the history

  2. sys: add *_INVALID values for interrupt and gpio constants 

    Create invalid value constants for intr_polarity and GPIO
pin/interrupts.  These are meant for internal use by drivers.
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    753b5a0 View commit details
    Browse the repository at this point in the history

  3. arm/arm64: use PIC settings for first handler instead of INTRNG inter… 

    …nals

Using PIC-private variables is superior as it keeps the PIC
implementation better separated from INTRNG's internals.  In turn this
eases changes to INTRNG.
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9c63963 View commit details
    Browse the repository at this point in the history

  4. intrng: add helper macro for use with ->isrc_handlers field 

    Add macros for future development.  Instead of always using `== 0`
everywhere, create a macro for testing for existance of handler(s).
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    30bc93e View commit details
    Browse the repository at this point in the history

  5. intrng: create stray handler for IPI interrupts 

    We most certainly don't want the shared interrupt system to mask IPI
interrupts.  As such report them to `dmesg` and indicate they're being
handled.
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    48366ee View commit details
    Browse the repository at this point in the history

  6. intrng: purge ->isrc_handlers value 

    The information is already available on the event, via a different
means.  Therefore retrieve it from there, rather than duplicating the
information.  Should be mild space savings, perhaps trivial speed due to
cache savings.  Should improve in future due to increasing numbers of
interrupts on recent systems.
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ac66e52 View commit details
    Browse the repository at this point in the history

  7. intr/x86: purge ->is_handlers value 

    Use of the macro CK_SLIST_EMPTY() on ->is_event->ie_handlers readily
substitues for the value ->is_handlers.  While only minor shrinkage of
struct intsrc, small reductions do accumulate.

Update the i8254 hack to work with this setup.
    @ehem
    ehem committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    2d231c9 View commit details
    Browse the repository at this point in the history