Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install xo_emit_f.3 #1406

Merged
merged 11 commits into from
Sep 21, 2024
Merged

Install xo_emit_f.3 #1406

merged 11 commits into from
Sep 21, 2024

Conversation

VoxSciurorum
Copy link
Contributor

No description provided.

@jlduran
Copy link
Member

jlduran commented Sep 3, 2024

Would it be too much to ask that you also submit it upstream?

https://github.com/Juniper/libxo/blob/fd5db1b4fba49e1f4c35d6c466710c0e89f54043/libxo/Makefile.am#L82

@VoxSciurorum
Copy link
Contributor Author

Would it be too much to ask that you also submit it upstream?

https://github.com/Juniper/libxo/blob/fd5db1b4fba49e1f4c35d6c466710c0e89f54043/libxo/Makefile.am#L82

Submitted as Juniper/libxo#97.

@bsdimp
Copy link
Member

bsdimp commented Sep 21, 2024

Thanks for submitting upstream. Pulled in until the next release is merged from there.

bsdimp pushed a commit to fichtner/freebsd-src that referenced this pull request Sep 21, 2024
Reviewed by: imp
Pull Request: freebsd#1406
fichtner and others added 11 commits September 21, 2024 05:25
These were reported by `mandoc -T lint` as
    ERROR: skipping unknown macro
When these pages were rendered with `man`, the "unknown macro" meant
that the entire line was omitted from the output.

Obvious typos in:
lib/libsys/swapon.2
lib/libsys/procctl.2
share/man/man9/firmware.9

lib/libcasper/services/cap_net/cap_net.3: 'mode' describes a function
    argument.

lib/libsys/statfs.2: there's no .Tm command ("trademark?"), and
    .Tn ("tradename") is deprecated, so remove the macro entirely.

usr.sbin/mfiutil/mfiutil.8: man was interpreting '/dev/' as a macro
    (which it didn't recognize).

share/man/man4/qat.4: same issue as above, but with '0'.  In this case,
    given the context of the previous line, rewriting as "Value '0'"
    seemed more appropriate.

usr.sbin/mlx5tool/mlx5tool.8: typo in .Xr

Signed-off-by:	Graham Percival <[email protected]>
Sponsored by:	Tarsnap Backup Inc.
Reviewed by:	concussious, imp
Pull Request:	freebsd#1417
Reviewed by: imp
Pull Request: freebsd#1406
1. Subtraction was performed on the current position
   regardless of the success of the lseek operation.
   In the event of an error, this resulted in the
   current position being erroneously set to -2,
   which bypassed the intended error handling
   mechanism. The proposed change performs error
   checking immediately following the lseek operation,
   prior to any modification of the current position.
   This ensures that a failed lseek operation will
   correctly trigger the appropriate error handling.

2. The error checking logic was based on the assumption
   that lseek would return `offset - 1` upon failure.
   However, this is not consistent with the behaviour of
   lseek as specified in the POSIX standard, which
   stipulates that lseek shall return -1 in case of
   an error. The code has been updated to reflect this
   standard, improving reliability and compliance.

Reviewed by: imp
Pull Request: freebsd#1392
Reviewed by: imp, kib
Pull Request: freebsd#1381
Reviewed by: imp, kib
Pull Request: freebsd#1381
Also provide an error message when argc is too long instead of printing
"no error message".

Reviewed by: imp, kib
Pull Request: freebsd#1381
dmesg for this device says:
> hn0: <Hyper-V Network Interface> on vmbus0

Add links so that `man hn` and `man if_hn` work.

MFC after:	3 days
Reviewed by: imp
Pull Request: freebsd#1377
+ while here, fix alignment and tag SPDX

MFC after:	3 days

Reviewed by: imp
Pull Request: freebsd#1421
@bsdimp bsdimp self-requested a review as a code owner September 21, 2024 11:25
@freebsd-git freebsd-git merged commit 2a680c5 into freebsd:main Sep 21, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants