Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pf.conf.5: additional quoting for ranges in lists #1516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pf.conf.5: additional quoting for ranges in lists #1516

wants to merge 2 commits into from

Commits on Nov 13, 2024

  1. pf.conf.5: additional quoting for ranges in lists 

    When defining network address ranges in macros that will later be used
as items in list macro, these ranges must be quoted with additiona
simple quotes.

For instance, the following does not work and is rejected as a syntax
error:

    usr = "192.168.1.0/24"
    srv = "192.168.2.10 - 192.168.29"
    nat_ranges = "{" $usr $srv "}"

Defining ranges as the following instead will work:
    usr = "'192.168.1.0/24'"
    srv = "'192.168.2.10 - 192.168.29'"

MFC after: 3 days
Reviewed by: Alexander Ziaee <[email protected]>
    @Defenso-QTH
    Defenso-QTH committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    50c46d9 View commit details
    Browse the repository at this point in the history

  2. pf.conf.5: use subsections and reword titles 

    The current manpage has two PARAMETERS top-level sections, which can be
confusing when searching or browsing documentation quickly.

Since the parameters described in these two sections are actually
applicable within the scope of the sections they follow (ETHERNET
FILTERING and PACKET FILTERING respectively), I propose we move them to
subsections.

I also propose we reword the title of one of those subsections to
facilitate quick searching or browsing.

MFC after: 3 days
Reviewed by: Alexander Ziaee <[email protected]>
    @Defenso-QTH
    Defenso-QTH committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c814f49 View commit details
    Browse the repository at this point in the history