u3g.4: increase visibility in apropos and release HW notes #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concussious
force-pushed
the
u3g.4
branch
3 times, most recently
from
51a9321
to
0565904
Compare
concussious
changed the title
concussious
force-pushed
the
u3g.4
branch
2 times, most recently
from
f8be01c
to
3b9c0bc
Compare
|
@jlduran maybe? |
bsdimp
reviewed
Nov 12, 2024
bsdimp
reviewed
Nov 12, 2024
| .It | ||
| Huawei B190, E180v, E220, E3372, E3372v153, E5573Cs322, ('<Huawei Mobile>') | ||
| Huawei B190, E180v, E220, E3372, E3372v153, E5573Cs322, etc. |
There was a problem hiding this comment.
Does this change lose information? Is Huawei Mobile just a generic company, or some specific branding these are sold under?
There was a problem hiding this comment.
When I googled I only found Huawei for each of the model numbers here. They are all sold under the Huawei brand. I think someone will /huawei on the manual or release notes.
emaste
reviewed
Nov 12, 2024
emaste
reviewed
Nov 12, 2024
|
Thank you so much sirs. |
Many people come on our social spaces asking about router projects, can't find info about supported cellular modems, and say they're sticking to $other_OS. Thanks to the fantastic talk by Ian from Metify, I now know that is not true, we have them and they work great. Therefore, tell everyone else by massaging this page for discoverability in the manual and the release hardware notes. + Document description: s/datacards/cellular modems/ for apropos search + HARDWARE: s/adapters/cellular modems/ for release hardware notes + move things which shouldn't be in Rel HW notes to description + massage things around for readability and flow + tag spdx + xref supported connections MFC after: 3 days Reported by: Jared Trout <[email protected]> (cellular in title) Reported by: emaste (specify mpd, editorial style instruction) Reported by: Metify (modem drivers exist)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: this is not discoverable in apropos or the release hw notes.
This is a small change but kind of a big deal because potential new users come to our social spaces and nobody thinks there's 4g modems so they say they'll stick with $otheros instead for their router project.
cellularandmodemto manual document description (apropos search keywords)cellularandmodemsto HARDWARE for search in the release hardware notes 1Unresolved questions, hopefully not obstructing this undocumented documentation bugfix:
cc @allanjude
Footnotes
Thus, please consider MFC to beta ↩