Introduce hints to ABI_FILE to select fat binary entries #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change ABI_FILE accepts an optional suffix separated by '#' from the path, this suffix is an architecture description, the same format as ALTABI after :.
The architecture hint is used to select a matching architecture from a Mach-O universal binary file.
Extend the pkg_abi_macho to use the provided architecture (hint) to select the right binary from an universal binary.
Add unit tests for this use case.
Also improve error handling and remove a memory leak.