Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpkg: remove dead file #2367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

libpkg: remove dead file #2367

wants to merge 1 commit into from

Conversation

ifreund
Copy link
Contributor

@ifreund ifreund commented Nov 29, 2024

This file has been dead since bdd5af5.

Sponsored by: The FreeBSD Foundation

This file has been dead since bdd5af5.

Sponsored by:	The FreeBSD Foundation
@kevemueller
Copy link

Hi Isaac, I had left the file around as not all of the functionality in it was incorporated (yet) in the new Mach-O code. Was delaying the libs functions for Mach-O in expectation that there will be a refactoring of shlibs provides/requires.
I might be just adding Mach-O with current libs functionality and then removing pkg_macho.c
Obviously I can retrieve this file from a previous commit, but I think it is clearer to remove the file once all of its functionality is there in the new (current) pkg_abi_macho.c.

@ifreund
Copy link
Contributor Author

ifreund commented Nov 29, 2024

This file's continued existence in the source tree confused me today when grepping for certain functions/variables landed me in this now dead code. As I was not familiar with the status of your work on macho support, it took me a bit to realize that this code was in fact dead.

In my opinion, leaving dead code in the source tree causes more confusion than its worth. I would prefer using an issue on the issue tracker to keep track of any functionality that is missing from the new pkg_abi_macho.c implementation.

I will of course defer to you and bapt though, I'm not personally working on macho related stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants