Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zpool altroot when creating datasets. #1018

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove zpool altroot when creating datasets. #1018

wants to merge 1 commit into from

Commits on Sep 27, 2023

  1. Remove zpool altroot from mountpoint when creating datasets. 

    If `${ZPOOL}` has `altroot` set, `${ZROOTFS}` can only be mounted
under `altroot`. This means `${BASEFS}` _must_ begin with `altroot`.

In `poudriere.conf`, the setting would look something like:
`BASEFS=<altroot>/rest/of/path`.

However, `altroot` is always prepended to whatever path is set to
`mountpoint` at the time of dataset creation. What happens is that
`${ZROOTFS}` is actually mounted on `<altroot>${BASEFS}`, while
`poudriere` thinks it's on `${BASEFS}`.

To fix the problem, simply check if `altroot` is set and remove it
from `mountpoint` when creating datasets. Their `mountpoint`s will
then be prepended with `altroot`, which matches `poudriere`'s internal
records.
    @kostaslambda
    kostaslambda authored and Kostas Ladopoulos committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    052090c View commit details
    Browse the repository at this point in the history