Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore automatically generated files by autoconf and automake #1108

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fel1x-developer
Copy link
Contributor

With change, developers can use newer versions of Autotools when it is not updated on FreeBSD ports.
Internal changes in Makefile.in, m4/, etc will be ignored when ./autogen.sh and ./configure

@bapt
Copy link
Member

bapt commented Jan 5, 2024

I actually plan to remove entirely autotools, (not fully decided yet) so I will take time to think about it more before merging this

@bdrewery
Copy link
Member

bdrewery commented Feb 19, 2024

build-aux/test-driver shouldn't be removed as it has customizations for the test framework.
I don't like the route here. Poudriere is supposed to be self-sufficient but this creates a dependency for no benefit. As for switching away from autotools I don't see the point there either. What we have works and the test framework is integrated into it.

@fel1x-developer
Copy link
Contributor Author

I don't like the route here. Poudriere is supposed to be self-sufficient but this creates a dependency for no benefit. As for switching away from autotools I don't see the point there either. What we have works and the test framework is integrated into it.

As autoconf and automake are already required, I don't think many users will be bothered by this change. libtool is a part of autotools (and also devel/autotools metaport), and autoconf-archive is also accessible to FreeBSD users with pkg or ports.

The benefit of this way is that we no longer need to update test-drivers/ and m4/ from the upstream autoconf-archive manually. Also, I don't think it's a good practice to keep automaticallly generated file under version control.

StackOverflow thread about this topic

@fel1x-developer
Copy link
Contributor Author

Since test-driver is customized for our own use, I agree that it should be tracked under version control.

@fel1x-developer
Copy link
Contributor Author

Fix merge conflict

/config.log
/config.status
/config.sub
/configure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i would keep configure in git for convenience

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configure file is machine-dependent (e.g. latest autoconf version can differ in different platforms), and it has to be updated manually on git. If someone forgets to update ./configure with autogen.sh and only push changes on autogen.sh, this might cause inconvinience for other devs, too.

If there is a way to always keep configure up-to-date, I will leave it out from .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants