Skip to content

Commit

Permalink
Lint our GitHub Actions workflows with zizmor
Browse files Browse the repository at this point in the history
We just need to set `persist-credentials: false` in all of our
workflows.

Refs <freedomofpress/securedrop-tooling#18>.
  • Loading branch information
legoktm committed Jan 3, 2025
1 parent b9efb8d commit 5476830
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
python3-poetry
- uses: actions/checkout@v4
with:
persist-credentials: false
lfs: true
- name: Install additional packages and Python dependencies
run: |
Expand All @@ -34,6 +35,7 @@ jobs:
apt-get update && apt-get install --yes --no-install-recommends make git git-lfs gnupg ca-certificates
- uses: actions/checkout@v4
with:
persist-credentials: false
lfs: true
- name: Verify checksums and signatures
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/reprotest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
python3-poetry
- uses: actions/checkout@v4
with:
persist-credentials: false
lfs: true
- name: Install additional packages and Python dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ SHELL := /bin/bash
lint:
@poetry run ruff check .
@poetry run ruff format --check .
@poetry run zizmor .

.PHONY: fix
fix:
Expand Down
25 changes: 24 additions & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ pytest = "*"
pytest-mock = "*"
ruff = "*"
virtualenv = "<16"
zizmor = "^1.0.0"

[tool.ruff]
line-length = 100
Expand Down

0 comments on commit 5476830

Please sign in to comment.