Remove (sys/sd)-whonix default prompt #2278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes out-of-the-box INFO Whonix systemcheck prompts. This is helpful for GUI tests. Furthermore, it should of no consequence to an end-user, since: - Derivative repo: it simply informs about the installed debian repositories. - Updates check: whonix-gateway-17 update checks are already enforced by our updater [1] Fixes https://github.com/freedomofpress/securedrop-client#2277 [1]: https://github.com/freedomofpress/securedrop-workstation/blob/f493665/sdw_updater/Updater.py#L51
legoktm
reviewed
Nov 6, 2024
| @@ -50,7 +50,7 @@ Package: securedrop-whonix-config | |||
| Section: admin | |||
| Architecture: all | |||
| # FIXME: s/tor/anon-gw-anonymizer-config/ (requires Whonix repositories in piuparts) | |||
| Depends: ${misc:Depends}, securedrop-qubesdb-tools, tor | |||
| Depends: ${misc:Depends}, securedrop-qubesdb-tools, tor, systemcheck | |||
There was a problem hiding this comment.
This is correct, but this is what's causing the piuparts jobs to fail (see the TODO). Let me work on that for you.
| @@ -1 +1,2 @@ | |||
| whonix-config/app_journalist.auth_private.tmpl /usr/share/securedrop-whonix-config | |||
| whonix-config/etc/systemcheck.d/50_securedrop.conf /etc/systemcheck.d/ | |||
There was a problem hiding this comment.
Since we're shipping a file in /etc/, we need to adapt the conffiles hack (see debian/rules) for the securedrop-whonix-config package as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Removes out-of-the-box
INFO-level Whonix systemcheck prompts. This is helpful for GUI tests. Furthermore, it should of no consequence to an end-user, since:Description
Fixes #2277
Test Plan
securedrop-whonix-configpackage in whonix-gateway-17 template and shut it downmake devin workstationChecklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration is self-contained and applies cleanlymainand would like the reviewer to do so