Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Rust toolchain to 1.84.1 #2379

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Upgrade Rust toolchain to 1.84.1 #2379

merged 1 commit into from
Feb 4, 2025

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Feb 3, 2025

Status

Ready for review

Description

No changes appear needed.

Fixes #2355.

Test Plan

  • CI passes, esp. proxy tests

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@legoktm legoktm requested a review from a team as a code owner February 3, 2025 23:14
No changes appear needed.

Fixes #2355.
@cfm cfm self-assigned this Feb 4, 2025
@cfm
Copy link
Member

cfm commented Feb 4, 2025

Rebased to get safety passing after #2376.

Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @legoktm.

@cfm cfm added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 6e45164 Feb 4, 2025
58 checks passed
@cfm cfm deleted the rust-1.84.1 branch February 4, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade Rust toolchain to 1.84.1
2 participants