Drop setting vm.heap_stack_gap and net.ipv4 sysctl flags #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
zenmonkeykstop
requested changes
Nov 4, 2024
| @@ -7,34 +7,6 @@ | |||
| testinfra_hosts = [sdvars.app_hostname, sdvars.monitor_hostname] | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
IMO keeping the testinfra checks makes sense, in case the metapackage-set values get borked somehow.
There was a problem hiding this comment.
OK, happy to leave it in for now but long-term I think we don't want to run into needing to constantly keep this repo updated if we change things in kernel-builder (but I doubt we'll be changing that many sysctl flags).
| @@ -81,7 +81,6 @@ def test_grsecurity_kernel_is_running(host): | |||
| [ | |||
| ("kernel.grsecurity.grsec_lock", 1), | |||
| ("kernel.grsecurity.rwxmap_logging", 0), | |||
| ("vm.heap_stack_gap", 1048576), | |||
There was a problem hiding this comment.
(repeat) IMO keeping the testinfra checks makes sense, in case the metapackage-set values get borked somehow.
These are now set via the securedrop-grsec metapackage (see <freedomofpress/kernel-builder#55>). Tests are left in to verify the migration works properly. Refs #7323.
legoktm
force-pushed
the
stg-less-sysctl
branch
from
3884e3f
to
37f1827
Compare
|
This should fail CI now because we haven't built new kernel packages yet, I will see about doing some today or tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
These are now set via the securedrop-grsec metapackage (see freedomofpress/kernel-builder#55).
Refs #7323.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment?
This can only be deployed after a kernel with freedomofpress/kernel-builder#55 is released stable. It's safe to merge ahead of time though once the kernel-builder one is approved.
Checklist