Copy backup to Admin Workstation before manual noble migration #7441
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the admin has manually initiated a backup, let's copy a backup to the Admin Workstation so it's easier to use. The backup is automatically deleted at the end of a successful playbook run. Especially for instances using SSH-over-Tor, this step may take a while, but if something does go wrong, it'll be nice. A backup is still taken on the server that stays on the server, there's no adverse effect except for a slight delay in waiting for the extraneous backup.
|
This is submitted without any testing or verifying of the ansible syntax - I'll try to do that early next week. |
|
At this point I'd rather not pull this in and just have people manually start a backup on their own. If they don't, we still have the on-server backup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Work in progress
Description of Changes
If the admin has manually initiated a backup, let's copy a backup to the Admin Workstation so it's easier to use. The backup is automatically deleted at the end of a successful playbook run.
Especially for instances using SSH-over-Tor, this step may take a while, but if something does go wrong, it'll be nice.
A backup is still taken on the server that stays on the server, there's no adverse effect except for a slight delay in waiting for the extraneous backup.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist
make -C admin test) pass in the admin development container