This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
onion service scanning: check meta tags for onion-location #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
changed the title
[wip] onion service scanning: check meta tags for onion-location
onion service scanning: check meta tags for onion-location
Sep 18, 2020
redshiftzero
force-pushed
the
meta-http-equiv
branch
from
September 18, 2020 20:15
e6bad08
to
a8a2dc4
Compare
redshiftzero
requested review from
chigby and
harrislapiroff
as code owners
September 18, 2020 20:33
chigby
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally seems great to me. A nice feature to have. I left a comment below about how many scans to run on the various URLs for a site, which you are free to consider and change if desired. Otherwise it's fine to merge as-is once this branch is rebased.
redshiftzero
force-pushed
the
meta-http-equiv
branch
from
September 28, 2020 21:32
a8a2dc4
to
e8ec6bc
Compare
thanks for reviewing! the last commit (e8ec6bc) is the new change here, the prior commits are just rebasing on the latest |
@redshiftzero This latest change looks great. I can merge once this is up-to-date with the base branch. |
redshiftzero
force-pushed
the
meta-http-equiv
branch
from
October 5, 2020 19:34
e8ec6bc
to
45975ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269. Followup to #262.
This PR:
requests
, parses the page content usinglxml
, then sees if there is anonion-location
meta tagThe easiest way to test once on this branch is to:
make dev-scan
http://127.0.0.1:8000/api/v1/sites/
onion_available
. Otherwise, Propublica should haveonion_available
as true, and techcrunch should haveonion_available
as false.