Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model parameter and makefile for compilation #16

Closed
wants to merge 6 commits into from

Conversation

sadath-12
Copy link

@sadath-12 sadath-12 commented Jul 16, 2023

What's new

  • This PR adds a new parameter to the freeedcom/ai-codereviewer Github Action: OPENAI_MODEL, which enables its users to customize the OpenAI model as needed.

  • Updated readme with more detailed contributing guide

  • Added Makefile for single command compilation

With these updates, it'll be possible to use another OpenAI model e.g. gpt-3.5-turbo instead and compile the code with command make compile

Copy link

@bbernstein bbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another pr open for just changing the model and it defaults to gpt-4. That may be a better default since that is the version described in the README file in a few places as well as the "About" of the github repo.

Also, not a biggie, but this got reformatted with different code editor settings than the original. Perhaps this repo could use a .eslintrc or something like that so formatting is consistent.

@villesau
Copy link
Contributor

Thanks for the contribution! This was addressed already in the other PR that was just merged. Don't hesitate to fix some further issues you might face though :)

@villesau villesau closed this Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants