Support latest gpt 4 #32

villesau · 2023-12-02T20:59:03Z

Support gpt-4-1106-preview and json mode

github-actions · 2023-12-02T20:59:37Z

src/main.ts

@@ -1,6 +1,6 @@
 import { readFileSync } from "fs";
 import * as core from "@actions/core";
-import { Configuration, OpenAIApi } from "openai";
+import OpenAI from "openai";


Directly importing OpenAI without destructuring may lead to potential issues if the library expects specific imports. Ensure that the OpenAI import aligns with the library's updated export structure for gpt-4-1106-preview and json mode.

github-actions · 2023-12-02T20:59:37Z

src/main.ts

@@ -98,7 +96,7 @@ async function getBaseAndHeadShas(

 function createPrompt(file: File, chunk: Chunk, prDetails: PRDetails): string {
  return `Your task is to review pull requests. Instructions:
- Provide the response in following JSON format:  [{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}]
+- Provide the response in following JSON format:  {"reviews": [{"lineNumber":  <line_number>, "reviewComment": "<review comment>"}]}


The JSON format provided in the updated line does not match the standard JSON array format. It should be an array of objects within square brackets [].

github-actions · 2023-12-02T20:59:37Z

src/main.ts

      ...queryConfig,
+      // return JSON if the model supports it:
+      ...(OPENAI_API_MODEL === "gpt-4-1106-preview"


The response_format object structure seems incorrect. The response_format should be a string, not an object. It should be 'response_format': 'json' if you want to specify JSON format.

github-actions · 2023-12-02T20:59:37Z

src/main.ts

@@ -152,8 +154,8 @@ async function getAIResponse(prompt: string): Promise<Array<{
      ],
    });

-    const res = response.data.choices[0].message?.content?.trim() || "[]";
-    return JSON.parse(res);
+    const res = response.choices[0].message?.content?.trim() || "{}";


The fallback value for res should be an empty array [] instead of an empty object {} to match the expected return type of the function.

github-actions · 2023-12-02T20:59:37Z

src/main.ts

-    const res = response.data.choices[0].message?.content?.trim() || "[]";
-    return JSON.parse(res);
+    const res = response.choices[0].message?.content?.trim() || "{}";
+    return JSON.parse(res).reviews;


Ensure that the property reviews exists on the parsed object to avoid potential runtime errors. Consider adding a check before accessing reviews property.

sarons · 2024-05-06T09:00:53Z

Hey @villesau, thanks for adding this but it doesn't seem to work. I think it worked first time, but later on I get the same error as #56

Run freeedcom/[email protected]
  
Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:151:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:151:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/freeedcom/ai-codereviewer/v2.7.0/webpack:/open-ai-reviewer/lib/main.js:151:1
    at Generator.next (<anonymous>)

sarons · 2024-05-06T09:39:50Z

@lukehollenback I also tried your branch #57, still the same error

Run lukehollenback/ai-codereviewer@issue-56_json-mode-on-more-models
  
Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/lukehollenback/ai-codereviewer/issue-56_json-mode-on-more-models/webpack:/open-ai-reviewer/lib/main.js:151:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/lukehollenback/ai-codereviewer/issue-56_json-mode-on-more-models/webpack:/open-ai-reviewer/lib/main.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

yagiz2000 · 2024-05-19T15:57:38Z

@lukehollenback I also tried your branch #57, still the same error

Run lukehollenback/ai-codereviewer@issue-56_json-mode-on-more-models
  
Error: SyntaxError: Unexpected token ` in JSON at position 0
    at JSON.parse (<anonymous>)
    at /home/runner/work/_actions/lukehollenback/ai-codereviewer/issue-56_json-mode-on-more-models/webpack:/open-ai-reviewer/lib/main.js:151:1
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/lukehollenback/ai-codereviewer/issue-56_json-mode-on-more-models/webpack:/open-ai-reviewer/lib/main.js:28:1)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Provide json response with reviews array and do not add any prefix or suffix just send reviews array.

If you add this prompt after - Provide the response in following JSON format: {"reviews": [{"lineNumber": <line_number>, "reviewComment": "<review comment>"}]} it will send json string without any prefix and json parse wont fail. (You can test it locally)

github-actions bot reviewed Dec 2, 2023

View reviewed changes

villesau force-pushed the support-latest-gpt-4 branch 2 times, most recently from 9b70faa to 82c725a Compare December 2, 2023 21:05

villesau added 2 commits December 2, 2023 23:08

support the latest gpt 4 and json mode

80ca662

package and update the model used, remove unused code

5c13a26

villesau force-pushed the support-latest-gpt-4 branch from 82c725a to 5c13a26 Compare December 2, 2023 21:08

villesau merged commit 8dff117 into main Dec 2, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support latest gpt 4 #32

Support latest gpt 4 #32

villesau commented Dec 2, 2023

github-actions bot Dec 2, 2023

github-actions bot Dec 2, 2023

github-actions bot Dec 2, 2023

github-actions bot Dec 2, 2023

github-actions bot Dec 2, 2023

sarons commented May 6, 2024

sarons commented May 6, 2024

yagiz2000 commented May 19, 2024 •

edited

Loading

Support latest gpt 4 #32

Support latest gpt 4 #32

Conversation

villesau commented Dec 2, 2023

github-actions bot Dec 2, 2023

Choose a reason for hiding this comment

github-actions bot Dec 2, 2023

Choose a reason for hiding this comment

github-actions bot Dec 2, 2023

Choose a reason for hiding this comment

github-actions bot Dec 2, 2023

Choose a reason for hiding this comment

github-actions bot Dec 2, 2023

Choose a reason for hiding this comment

sarons commented May 6, 2024

sarons commented May 6, 2024

yagiz2000 commented May 19, 2024 • edited Loading

yagiz2000 commented May 19, 2024 •

edited

Loading