Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ordering front end redesign #4595
base: main
Are you sure you want to change the base?
Ordering front end redesign #4595
Changes from all commits
4cb004f
2ac21c6
c260b60
08a4e86
bc92162
be333b3
5b0cf27
7e8a9e2
d15e349
353ebd2
e3fa07e
1ad1040
dfdca1f
dbe7bf3
d210bdd
6477b6f
3d96869
70c0c49
1735fae
3c009be
ecd7bb2
7606b51
0117ed0
7170885
f33d192
8aa0950
97405c8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this log might be a leftover from debugging. Would it be okay to remove it to reduce console clutter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can optimize this event listener by implementing a few tweaks. Here's a breakdown:
Reduce Iterations: Instead of looping through all nav links twice, we can initially query only the links with the active class. This significantly reduces the number of elements to process in the first loop.
Use Unique IDs: To streamline the process further, we can assign unique IDs to the target anchors. This allows us to directly target the specific element using
getElementById
, eliminating the need for a second loop and href attribute comparisons.Here's my suggestion for this event listener:
Beyond the script adjustments, we'll need to add IDs to the
opinions.html
template. To make this refactor easier to review, I've created a new branch. You can check the diff here:https://github.com/freelawproject/courtlistener/compare/ordering-front-end-redesign...ERosendo:courtlistener:refactor-scroll-event-lister?expand=1