Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mass): Use different endpoint for Mass #1243

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

flooie
Copy link
Contributor

@flooie flooie commented Nov 19, 2024

PR hopefully addresses issue #1237

This may be temporary but we need to scrape
Massachusetts's social law library website for
opinions at the moment.

Uses the JSON endpoint to get the case and adds code to cleanup the HTML found

This may be temporary but we need to scrape
Massachusetts's social law library website for
opinions at the moment.
@flooie flooie requested a review from grossir November 19, 2024 18:05
Copy link
Contributor

@grossir grossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments that I think may improve this scraper
The formatted HTML looks OK
image

juriscraper/opinions/united_states/state/mass.py Outdated Show resolved Hide resolved
juriscraper/opinions/united_states/state/mass.py Outdated Show resolved Hide resolved
juriscraper/opinions/united_states/state/mass.py Outdated Show resolved Hide resolved
juriscraper/opinions/united_states/state/mass.py Outdated Show resolved Hide resolved
@flooie flooie requested a review from grossir November 19, 2024 21:30
@flooie flooie assigned grossir and unassigned flooie Nov 19, 2024
Copy link
Contributor

@grossir grossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine, feel free to merge it. I see it's now addressing #1244 too

@grossir grossir merged commit 2e51b45 into main Nov 19, 2024
12 checks passed
@grossir grossir deleted the mass-social-scraper branch November 19, 2024 22:52
@flooie
Copy link
Contributor Author

flooie commented Nov 21, 2024

Thanks @grossir - did we release this yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants