687 Fix docket report parsing on view multiple documents layout #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…documents layout - Since there are layouts where the Download Selected button is not available, see: nvb_368678.html
mlissner
approved these changes
May 31, 2023
|
Will you get this deployed please, as usual, too? |
|
Sure, Juriscraper update is released, and Courtlistener update it's being deployed now. |
ttys0dev
reviewed
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #687.
When the "View multiple documents" option is enabled on PACER, the docket entries table contains an extra column with a checkbox input to select the displayed documents.
Previously, this extra cell was removed when the checkbox was present within the cell. However, the problem arose when there was no checkbox in this extra cell, such as with sealed documents or entries without an attached document. As a result, the cell was not removed, causing a parsing mismatch.
A similar issue occurred with bankruptcy dockets, where there is an extra empty cell before the entry number. As a result, the entry number was incorrectly placed in the description field, while the entry number itself remained null.
To resolve the problem, the "View multiple documents" docket report is now detected by checking for the presence of the "View Selected" underneath the entries table so the correct indexes are used for each case.
Regarding tests, there are multiple tests for "View multiple documents" docket reports on appellate dockets. However, only two tests were available for bankruptcy dockets (nvb_368678.html, kywb_238163.html), but they did not cover the scenarios where this issue occurred (numbered entries without the checkbox input). So this issue was not previously detected.